Cup scene, Fluid problem

So I wanted to try fluid simulation for the first time, as you can see, I made this cup, and the fluid seems to pass it, I tried tinkering with the settings a lot, the cup is an obstacle and the volume is shell. Can someone help?