is this the best way to unwrap this object?
It is a low distortion way to unwrap it.
Can two of the sides share texture space? that would leave you a square texture map with the top, bottom and two sides.
Is it for a game? Will it be normal mapped? and are any edges going to be marked sharp?